Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose proxies in Server and ApiRoot classes. #56

Merged

Conversation

emmanvg
Copy link
Contributor

@emmanvg emmanvg commented Nov 8, 2018

closes #51

Add optional argument proxies to all Endpoints to allow for proxy settings.

@emmanvg emmanvg added this to the 0.5.0 milestone Nov 8, 2018
@emmanvg emmanvg requested a review from clenk November 8, 2018 18:47
@codecov-io
Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #56 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   96.25%   96.25%   +<.01%     
==========================================
  Files           2        2              
  Lines         827      828       +1     
==========================================
+ Hits          796      797       +1     
  Misses         31       31
Impacted Files Coverage Δ
taxii2client/__init__.py 92.58% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ab74e...b4c365b. Read the comment docs.

Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as a quick-fix until a longer-term solution is ready. Thanks, @emmanvg!

@clenk clenk merged commit 9f9386b into oasis-open:master Nov 9, 2018
@emmanvg emmanvg deleted the 51-expose-proxies-to-other-endpoints branch October 30, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server() function doesn't return when using both user:password and proxies
3 participants