Updated basic_filter to be in line with 2.1 spec, updated tests and default_data to match spec, and fixed some issues with the memory_backend pertaining to 2.1 objects #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nded print statements from memory_backend
|
Just to be clear, these commits are failing the Travis tests because the tests being used are not updated to expect 2.1 spec data nor logic. Some basic changes to the tests have been included already, but future commits will commits should contain code that tests new features and updated parts of the spec. |
…mplemented correctly
…default_data to reflect the example in the spec, and updated a few tests in test_memory_backend
…n) now instead of O(n^3)
… to its own function. Also made sure that time comparisons are always done with datetime objects
…pon recommendations
…f it's appropriate
|
I have finished merging @zrush-mitre code into my PR #63. Thus, we can go ahead and close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the TAXII filter to be up to spec for 2.1. Also changed the default_data to be representative of data expected on a 2.1 server, and changed some small things in the memory_backend to try to make the tests run.