Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregator schema typo mirror #663

Closed
3 tasks done
tschmidtb51 opened this issue Nov 23, 2023 · 4 comments
Closed
3 tasks done

Aggregator schema typo mirror #663

tschmidtb51 opened this issue Nov 23, 2023 · 4 comments
Assignees
Labels
bug csaf 2.0 csaf 2.0 work oasis_tc_process OASIS TC process action

Comments

@tschmidtb51
Copy link
Contributor

tschmidtb51 commented Nov 23, 2023

In the aggregator schema, we have a typo:

lists mirror as required field - but the real name should be mirrors according to our naming logic and

Tasks:

  • Discuss how that can be fixed (also in the aggregator.json schema)
  • Check, why this hasn't come up during schema checks
  • Implement test to prevent this mistakes
@sthagen
Copy link
Contributor

sthagen commented Nov 24, 2023

Naming is Hard

As a software engineer I like to have the names optimal (not ideal) as the effort required to approach the latter may not be adequate.

But eitherway (fixing on spec level or not), I think that the first order of business in such cases (no prose but a schema i.e. a contract between (machine) agents) is to reach an understanding of two related facts:

  1. the scope (deployment so far) of distribution needed for any change from our side
  2. the hardness of coupling introduced by the actors specifically finding out if they
    a. either adapt their agents
    b. or insist on automatic derivation (from our schema)

Maybe the cost of change is not worth to maintain a perspective of perfect model expression.

After all, we could have named that key also abadcafe ... as long as the titles / descriptions in the schema (often used by tool builders to serve the human users) expose the intented meaning and thus foster value quality of the entries.

Even if we mess up the titles / descriptions, I learned, implementers come back and ask and then fix it for us in real life, kind of.

@sthagen
Copy link
Contributor

sthagen commented Dec 1, 2023

As discussed in our weekly editor call, I will send a request to TC admins and in copy to our chair to answer the question:

Is our OASIS errata process adequate for adding a single character "s" into the key of our aggregator schema?

The prose is not impacted, as in the examples in there, the correct plural form is used.

The problem is, that no one seems to use the aggregator role in full for now and the fix is required. Otherwise it is not possible to have an aggregator JSON file that is valid against the schema.

tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Dec 4, 2023
- addresses parts of oasis-tcs#663
- correct typo
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Dec 4, 2023
- addresses parts of oasis-tcs#663
- add example to make sure change is correct
@tschmidtb51 tschmidtb51 added the oasis_tc_process OASIS TC process action label Dec 4, 2023
@sthagen
Copy link
Contributor

sthagen commented Dec 6, 2023

This comment is to acknowledge the receipt of the CSAF v2.0 Errata 01 starter document.

I did commit the file at

https://github.com/oasis-tcs/csaf/blob/csaf-2.0-errata-01-starter/csaf_2.0_errata_01/index.md

and tagged to our (this) TC repository:

https://github.com/oasis-tcs/csaf/releases/tag/csaf-2.0-errata-01-starter

tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Dec 8, 2023
- addresses part of oasis-tcs#663
- add JSON documents for Errata
tschmidtb51 added a commit to tschmidtb51/csaf that referenced this issue Dec 8, 2023
- addresses motion of oasis-tcs#663
- add JSON schemas as artifacts to errata directory
@tschmidtb51
Copy link
Contributor Author

@sthagen I guess that can be closed, right?

@sthagen sthagen closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug csaf 2.0 csaf 2.0 work oasis_tc_process OASIS TC process action
Projects
None yet
Development

No branches or pull requests

2 participants