-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregator schema typo mirror
#663
Comments
Naming is HardAs a software engineer I like to have the names optimal (not ideal) as the effort required to approach the latter may not be adequate. But eitherway (fixing on spec level or not), I think that the first order of business in such cases (no prose but a schema i.e. a contract between (machine) agents) is to reach an understanding of two related facts:
Maybe the cost of change is not worth to maintain a perspective of perfect model expression. After all, we could have named that key also Even if we mess up the titles / descriptions, I learned, implementers come back and ask and then fix it for us in real life, kind of. |
As discussed in our weekly editor call, I will send a request to TC admins and in copy to our chair to answer the question:
The prose is not impacted, as in the examples in there, the correct plural form is used. The problem is, that no one seems to use the aggregator role in full for now and the fix is required. Otherwise it is not possible to have an aggregator JSON file that is valid against the schema. |
- addresses parts of oasis-tcs#663 - correct typo
- addresses parts of oasis-tcs#663 - add example to make sure change is correct
This comment is to acknowledge the receipt of the CSAF v2.0 Errata 01 starter document. I did commit the file at https://github.com/oasis-tcs/csaf/blob/csaf-2.0-errata-01-starter/csaf_2.0_errata_01/index.md and tagged to our (this) TC repository: https://github.com/oasis-tcs/csaf/releases/tag/csaf-2.0-errata-01-starter |
- addresses part of oasis-tcs#663 - add JSON documents for Errata
- addresses motion of oasis-tcs#663 - add JSON schemas as artifacts to errata directory
@sthagen I guess that can be closed, right? |
In the aggregator schema, we have a typo:
csaf/csaf_2.0/json_schema/aggregator_json_schema.json
Line 178 in 5757eeb
lists
mirror
as required field - but the real name should bemirrors
according to our naming logic andcsaf/csaf_2.0/json_schema/aggregator_json_schema.json
Line 187 in 5757eeb
Tasks:
The text was updated successfully, but these errors were encountered: