-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDMA Capability support details #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssamudrala
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see references to,
VIRTCHNL2_OP_CONFIG_RDMA_IRQ_MAP
VIRTCHNL2_OP_RELEASE_RDMA_IRQ_MAP
in the Virtual Channel API's section. Maybe explicitly mark as reserved there.
Thanks guys for review feedback, will pull in the fix and update the PR today. So we can merge tomorrow.
From: shirazsaleem ***@***.***>
Sent: Tuesday, March 12, 2024 8:14 AM
To: oasis-tcs/idpf-specification ***@***.***>
Cc: Singhai, Anjali ***@***.***>; Author ***@***.***>
Subject: Re: [oasis-tcs/idpf-specification] RDMA Capability support details (PR #14)
@shirazsaleem commented on this pull request.
________________________________
In idpf_specification.md<#14 (comment)>:
@@ -11541,3 +11520,133 @@ union virtchnl2_rx_desc {
#endif /* _VIRTCHNL_LAN_DESC_H_ */
```
+# Appendix : Linux RDMA
+
+## North Side Interfaces and flows for Linux:
+This section is not part of the main spec and it is just an example implementation detail referred from the Linux support for RDMA driver.
+
+### RDMA Aux drivers naming
+IDPF driver will create a Core and multiple vPort level Aux device instances for RDMA. The Core RDMA device driver will setup the Control Queues with RDMA FW and any other Interface level initialization and the Vport Aux device instance can be one to one with the LAN vport netdev instances. Although not ever Lan vPort netdev may not create a RDMA vport Ib driver instance as discussed earlier.
+( Note: TBD, the LAN driver itself is also undergoing changes to create LAN netdevs as Aux device instances on the aux bus. Although RDMA vPort Aux device instances are not dependent on the LAN Aux Devices per Netdev and so the work can be done independently)
+RDMA Aux devices will be named carrying the following key words in the name: IDPF, VENDOR ID, RDMA, , TYPE OF the DEVICE (CORE or VPort), A Global ID
+This allows for a unique vendor specific RDMA driver to be loaded along with IDPF driver.
+The Global unique ID, is requested from the OS and helps identify individual Aux driver instances.
+### RDMA Driver bring up and teardown flows
bring-up is called out in this section but there is little mention of the tear-down flow.
—
Reply to this email directly, view it on GitHub<#14 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJY7XPZNDNWVXJR7BS7FUDYX4LR5AVCNFSM6AAAAABEIHQ2AOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZRGM3DQOBXHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
RDMA PR merged with all the feedback fixes made.
Thanks
Anjali
From: Singhai, Anjali
Sent: Tuesday, March 12, 2024 8:33 AM
To: oasis-tcs/idpf-specification ***@***.***>; oasis-tcs/idpf-specification ***@***.***>
Cc: Author ***@***.***>
Subject: RE: [oasis-tcs/idpf-specification] RDMA Capability support details (PR #14)
Thanks guys for review feedback, will pull in the fix and update the PR today. So we can merge tomorrow.
From: shirazsaleem ***@***.***>
Sent: Tuesday, March 12, 2024 8:14 AM
To: oasis-tcs/idpf-specification ***@***.***>
Cc: Singhai, Anjali ***@***.***>; Author ***@***.***>
Subject: Re: [oasis-tcs/idpf-specification] RDMA Capability support details (PR #14)
@shirazsaleem commented on this pull request.
________________________________
In idpf_specification.md<#14 (comment)>:
@@ -11541,3 +11520,133 @@ union virtchnl2_rx_desc {
#endif /* _VIRTCHNL_LAN_DESC_H_ */
```
+# Appendix : Linux RDMA
+
+## North Side Interfaces and flows for Linux:
+This section is not part of the main spec and it is just an example implementation detail referred from the Linux support for RDMA driver.
+
+### RDMA Aux drivers naming
+IDPF driver will create a Core and multiple vPort level Aux device instances for RDMA. The Core RDMA device driver will setup the Control Queues with RDMA FW and any other Interface level initialization and the Vport Aux device instance can be one to one with the LAN vport netdev instances. Although not ever Lan vPort netdev may not create a RDMA vport Ib driver instance as discussed earlier.
+( Note: TBD, the LAN driver itself is also undergoing changes to create LAN netdevs as Aux device instances on the aux bus. Although RDMA vPort Aux device instances are not dependent on the LAN Aux Devices per Netdev and so the work can be done independently)
+RDMA Aux devices will be named carrying the following key words in the name: IDPF, VENDOR ID, RDMA, , TYPE OF the DEVICE (CORE or VPort), A Global ID
+This allows for a unique vendor specific RDMA driver to be loaded along with IDPF driver.
+The Global unique ID, is requested from the OS and helps identify individual Aux driver instances.
+### RDMA Driver bring up and teardown flows
bring-up is called out in this section but there is little mention of the tear-down flow.
—
Reply to this email directly, view it on GitHub<#14 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHJY7XPZNDNWVXJR7BS7FUDYX4LR5AVCNFSM6AAAAABEIHQ2AOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMZRGM3DQOBXHE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the RDMA flow and capability negotiation details beyond what was captured in the initial Spec.
It also adds an Appendix describing the Interaction between the standard vendor agnostic IDPF driver and the RDMA vendor driver in case of Linux called the North side interaction. Other OS may implement this another way and hence its not part of the main Spec region.