get rid of controlled vocabularies module, allow sources on examples #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gotten rid of the controlled vocabularies module and moved its contents into the other modules (and into the core).
I've renamed some of the folders in the DocBook folder structure to bring them into compliance with our own terminology: "objects" to "dataTypes" and so on, and changed the titles of the various sections to make them less wordy: "Sense object type" to just "Sense" and so on.
I've added quite a few examples to the internal linking module to illustrate how the relation types such as SensePair and SenseSet are supposed to be used.
I've updated the Example type to make it possible to encode sources and attributions for example sentences.