Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODATA-1506: Allow numeric index segment in path expressions #59

Draft
wants to merge 10 commits into
base: v4.02-release-candidate
Choose a base branch
from

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Jan 18, 2022

This is an alternative to #61

Copy link

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@@ -564,12 +564,15 @@ collectionPathExpr = count [ OPEN expandCountOption *( SEMI expandCountOption )
/ "/" allExpr
/ "/" boundFunctionExpr
/ "/" annotationExpr
/ "/" indexExpr
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the less invasive variant

$orderby=components($orderby=name;$index=0)/name

so we need not introduce index segments.

Copy link
Contributor Author

@ralfhandl ralfhandl Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also require extending the path expression syntax, allowing nested query options - at least $orderby and $index, see #61

@ralfhandl ralfhandl changed the base branch from main to v4.02-release-candidate October 27, 2023 09:39
Copy link

@sthagen sthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice space compression 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants