Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commonExpr in aggregate expressions of type 2 #98

Merged
merged 9 commits into from
Jun 14, 2023

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented May 5, 2023

Aggregate expressions of type 2 are aggregatable expressions as defined in OData-Aggr. Represent them by the commonExpr rule in ABNF.

The aggregate follows a collection-valued path or $these (current collection) and don't use lambda variables.

@HeikoTheissen HeikoTheissen marked this pull request as ready for review May 5, 2023 14:49
@HeikoTheissen HeikoTheissen changed the title Restrict aggregate function on current collection Restrict aggregate function with lambda variables to type 2 May 5, 2023
@HeikoTheissen HeikoTheissen changed the title Restrict aggregate function with lambda variables to type 2 Allow commonExpr in aggregate expressions of type 2 May 17, 2023
@HeikoTheissen HeikoTheissen merged commit 12f59ff into aggregation-cs03-release-candidate Jun 14, 2023
1 check passed
@HeikoTheissen HeikoTheissen deleted the aggregate-type-2 branch June 14, 2023 15:27
HeikoTheissen pushed a commit that referenced this pull request Oct 18, 2023
* ODATA-1442 - Update Aggregation ABNF with changes from previous issues (#35)
* ODATA-1384: Node value property path in hierarchical transformations (#72)
* ODATA-1468: Paths in aggregate in analogy with groupby (#75)
* ODATA-1391 - Enable usage of $this and $root in filter transformation (#34)
* ODATA-1533: Generalize 4th parameter of ancestors/descendants (#80)
* countdistinct and custom aggregation methods can aggregate non-primitive values (#81)
* `from` multiple dimensions (#82)
* ODATA-1532: OData-Aggr WD05 sections 3.10.2.2 and 3.22 (#79)
* Walkthrough OData-Aggr 3.2 (#85)
* Incomplete searchExpr in $apply=search (#84)
* Allow aggregation with paths ending in a type-cast (#91)
* $count after single-valued primitive segment (#92)
* Abolish transformnested (#95)
* Allow lambda variables in aggregate function (#93)
* "@odata.context": "$metadata#EntitySet(@Core.AnyStructure)" (#94)
* Optional parameters for rolluprecursive (#86)
* Allow `commonExpr` in aggregate expressions of type 2 (#98)
* Remove optional parameter from `ancestors` and `descendants` (#100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants