Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODATA-1429 #130

Merged
merged 6 commits into from Oct 11, 2023
Merged

ODATA-1429 #130

merged 6 commits into from Oct 11, 2023

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 17, 2023

HeikoTheissen
HeikoTheissen previously approved these changes Aug 18, 2023
HeikoTheissen
HeikoTheissen previously approved these changes Aug 18, 2023
odata-protocol/11 Data Service Requests.md Show resolved Hide resolved
[`$select`](#SystemQueryOptionselect),
`$expand`, and
[`$compute`](#SystemQueryOptioncompute), plus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "plus" helpful? Why not a plain comma-separated list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "plus" introduces the ones only for collection-valued navigation properties

[`$select`](#SystemQueryOptionselect),
`$expand`, and
[`$compute`](#SystemQueryOptioncompute), plus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "plus" helpful? Why not a plain comma-separated list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "plus" introduces the ones only for collection-valued navigation properties

[`$select`](#SystemQueryOptionselect),
`$expand`, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "and" helpful? Why not a plain comma-separated list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first three are for all navigation properties (added now)

GeraldKrause
GeraldKrause previously approved these changes Aug 30, 2023
mikepizzo
mikepizzo previously approved these changes Oct 11, 2023
@ralfhandl ralfhandl merged commit f40263b into main Oct 11, 2023
1 check passed
@ralfhandl ralfhandl deleted the ODATA-1429 branch October 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants