Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODATA-1495 #145

Merged
merged 4 commits into from Nov 8, 2023
Merged

ODATA-1495 #145

merged 4 commits into from Nov 8, 2023

Conversation

ralfhandl
Copy link
Contributor

@ralfhandl ralfhandl commented Aug 18, 2023

HeikoTheissen
HeikoTheissen previously approved these changes Aug 18, 2023
Copy link
Contributor

@GeraldKrause GeraldKrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change now refers to the format-specific representation also when creating an entity. This was not discussed in https://issues.oasis-open.org/browse/ODATA-1495.
Is this generally true for creating entities, also without an OData-Version header with a value of 4.01?

@ralfhandl
Copy link
Contributor Author

The change now refers to the format-specific representation also when creating an entity. This was not discussed in https://issues.oasis-open.org/browse/ODATA-1495.

I took the liberty of globally searching for "base64url-encoded" and replacing it in both places with "format-specific", which I think is correct.

Is this generally true for creating entities, also without an OData-Version header with a value of 4.01?

Good question, could you please create a new issue for it?

@GeraldKrause
Copy link
Contributor

Alright, I will create a new Jira issue for this question. Let's put this PR on hold until we have clarified this point, because the current change assumes that the rule applies for creating entities also without the OData-Version header.

@GeraldKrause
Copy link
Contributor

@ralfhandl After reading the text again I now find it simpler to discuss this remaining question in the context of the existing ODATA-1495. I added a comment to the issue that we can use to clarify it.

HeikoTheissen
HeikoTheissen previously approved these changes Oct 19, 2023
@ralfhandl ralfhandl merged commit 0ec47cd into main Nov 8, 2023
1 check passed
@ralfhandl ralfhandl deleted the ODATA-1495 branch November 8, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants