Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: adapted to latest working draft #118

Merged
merged 84 commits into from Jul 22, 2021
Merged

Temporal: adapted to latest working draft #118

merged 84 commits into from Jul 22, 2021

Conversation

ralfhandl
Copy link
Contributor

  • Remove system time
  • Support time-slice collections per temporal object

@ralfhandl ralfhandl marked this pull request as ready for review May 7, 2021 12:16
HeikoTheissen
HeikoTheissen requested changes May 10, 2021
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment above.

HeikoTheissen
HeikoTheissen previously approved these changes May 21, 2021
View reviewed changes
ralfhandl
ralfhandl commented Jul 12, 2021
View reviewed changes
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
ralfhandl
ralfhandl commented Jul 12, 2021
View reviewed changes
Copy link
Contributor Author

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are getting there...

vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
HeikoTheissen
HeikoTheissen requested changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When speaking of entity sets with visible data history, avoid the term "time slice" in favor of "period". Speak of "time slices" in the action definitions, which can be applied to entity sets with or without visible data history.

vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
ralfhandl and others added 2 commits July 13, 2021 14:08
@ralfhandl @HeikoTheissen
Apply suggestions from code review
8e9d0a9 
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
@ralfhandl
Refreshed
7148a59
HeikoTheissen
HeikoTheissen requested changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SupportedActions independent of the DataHistory

vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
vocabularies/Org.OData.Temporal.V1.xml Outdated Show resolved Hide resolved
ralfhandl and others added 3 commits July 14, 2021 10:15
@ralfhandl @HeikoTheissen
Apply suggestions from code review
f81b627 
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
@ralfhandl
Refreshed
54739f8
@HeikoTheissen
regeneration
559c728
ralfhandl and others added 6 commits July 14, 2021 10:21
@ralfhandl
Merge branch 'temporal' of https://github.com/oasis-tcs/odata-vocabul…
bf22dfd 
…aries into temporal
@HeikoTheissen
+SQL reference for Delete action
c17f743
@HeikoTheissen
Merge branch 'temporal' of git@github.com:oasis-tcs/odata-vocabularie…
7980738 
…s.git into temporal
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into temporal
142928c 
Conflicts:
	vocabularies/Org.OData.Core.V1.md
@HeikoTheissen @ralfhandl
TC discussion 2021-07-15 (#138)
fe9f00c 
* TC discussion 2021-07-15

* PeriodStart&End, timeline instead of history

Co-authored-by: Ralf Handl <ralf.handl@sap.com>
@ralfhandl
Minor changes
330a7c6
@ralfhandl ralfhandl merged commit 46800c7 into main Jul 22, 2021
@ralfhandl ralfhandl deleted the temporal branch July 22, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoTheissen HeikoTheissen HeikoTheissen approved these changes

@GeraldKrause GeraldKrause Awaiting requested review from GeraldKrause

@chrisspre chrisspre Awaiting requested review from chrisspre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralfhandl @HeikoTheissen