Changes resulting from OData-Aggr walkthrough #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfhandl
requested changes
May 23, 2022
ralfhandl
approved these changes
May 23, 2022
and the schema is called SalesModel
ralfhandl
approved these changes
May 23, 2022
HeikoTheissen
changed the title
ralfhandl
approved these changes
Sep 2, 2022
…te' into walkthrough
ralfhandl
reviewed
Jun 6, 2023
ralfhandl
requested changes
Jun 6, 2023
ralfhandl
approved these changes
Jun 6, 2023
HeikoTheissen
commented
Jun 7, 2023
Comment on lines
+104
to
+106
| <String>Services that do not fully implement a certain aggregation-related functionality may document | ||
| this by annotating the [`ApplySupported`](#ApplySupported) or [`ApplySupportedDefaults`](#ApplySupportedDefaults) | ||
| annotation with a description.</String> |
There was a problem hiding this comment.
Is that acceptable?
HeikoTheissen
commented
Jun 7, 2023
| @@ -287,19 +343,25 @@ | |||
| </Term> | |||
|
|
|||
| <Term Name="LeveledHierarchy" Type="Collection(Edm.PropertyPath)" Nullable="false" AppliesTo="EntityType ComplexType"> | |||
| <Annotation Term="Core.Description" String="Defines a leveled hierarchy by defining an ordered list of properties in the hierarchy" /> | |||
| <Annotation Term="Core.Description" String="Defines a leveled hierarchy (OData-Data-Agg-v4.0, section 5.5.1)" /> | |||
There was a problem hiding this comment.
Give short description of a leveled hierarchy.
| </Term> | ||
|
|
||
| <Term Name="RecursiveHierarchy" Type="Aggregation.RecursiveHierarchyType" Nullable="false" AppliesTo="EntityType"> | ||
| <Annotation Term="Core.Description" String="Defines a recursive hierarchy." /> | ||
| <Annotation Term="Core.Description" String="Defines a recursive hierarchy (OData-Data-Agg-v4.0, section 5.5.2)" /> |
There was a problem hiding this comment.
Give short description of a recursive hierarchy.
ralfhandl
approved these changes
Jun 14, 2023
HeikoTheissen
merged commit fc8c776
into
aggregation-cs03-release-candidate
1 check passed
HeikoTheissen
added a commit
that referenced
this pull request
Oct 18, 2023
* ODATA-1218 - Enhance hierarchy processing (#121) * ODATA-1142 - resolved - Clarify MaxDistance is an optional parameter in hierarchy filter functions (#78) * ODATA-1136 - resolved - Allow hierarchy filter functions for ancestors and descendants ... (#77) * ODATA-1384 - Clarify usage of annotation qualifiers as references to hierarchies (#125) * Digital/Physical -> Food/NonFood (#186) * Aggregation voc - update descriptions: remove rollupall, add rolluprecursive (#193) * Preview on new transformations (#218) * Changes resulting from OData-Aggr walkthrough (#191) * remove commented-out Cycle term (#221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.