Skip to content

Commit

Permalink
Merge #280: result.rank.
Browse files Browse the repository at this point in the history
  • Loading branch information
Larry Golding committed Nov 29, 2018
1 parent a6e5aed commit 4c2d0b8
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
Binary file modified Documents/ProvisionalDrafts/sarif-v2.0-csd02-provisional.docx
Binary file not shown.
16 changes: 10 additions & 6 deletions Documents/Schema changes between SARIF v1 and v2.md
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,16 @@ Start of changes for CSD.2
- `firstDetectionRunInstanceGuid` of type `string`, optional.
- `lastDetectionRunInstanceGuid` of type `string`, optional.

- [Issue #280](https://github.com/oasis-tcs/sarif-spec/issues/280): "Provide optional result.rank value of 0.0 to 100.0"

In the `result` object:

- Add a `rank` property of type `number`, `optional`, `minValue: 0.0`, `maxValue: 100.0`.

In the `ruleConfiguration` object:

- Add a `defaultRank` property of type `number`, `optional`, `minValue: 0.0`, `maxValue: 100.0`.

- [Issue #283](https://github.com/oasis-tcs/sarif-spec/issues/283): "result.message SHALL be present constraint should be added to schema"

In the `result` object:
Expand Down Expand Up @@ -1114,12 +1124,6 @@ Start of changes for CSD.2
- Modify the _comment_ on the `kind` property to remove mention of `"package"` and `"function"`.
(The property is a `string`, not an `enum`, so only the comment needs to change.)

- [Issue #280](https://github.com/oasis-tcs/sarif-spec/issues/280): "Provide optional result.rank value of 0.0 to 100.0" -- made available on November 26th, 2018.

In the `result` object:

- Add a `rank` property of type `number`, `optional`, `minValue: 0.0`, `maxValue: 100.0`.

- [Issue #285](https://github.com/oasis-tcs/sarif-spec/issues/285): "Provide a mechanism to associate a result with an invocation."

In the `resultProvenance` object:
Expand Down
2 changes: 2 additions & 0 deletions EditorsReports/Editor's report 2018-12-12.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ Presented at TC Meeting #29, December 12th, 2018
1. After being approved as amended at the last TC meeting (#28), the following spec changes were merged into the provisional draft:

1. [Issue #188](https://github.com/oasis-tcs/sarif-spec/issues/188): "Specify a default value for columnKind"

1. [Issue #280](https://github.com/oasis-tcs/sarif-spec/issues/280): "Provide optional result.rank value of 0.0 to 100.0"

0 comments on commit 4c2d0b8

Please sign in to comment.