Skip to content

Commit

Permalink
Update schema changes document for #248, #270, and #293
Browse files Browse the repository at this point in the history
  • Loading branch information
Larry Golding committed Jan 3, 2019
1 parent b63ae4e commit e814d6e
Showing 1 changed file with 16 additions and 16 deletions.
32 changes: 16 additions & 16 deletions Documents/Schema changes between SARIF v1 and v2.md
Original file line number Diff line number Diff line change
Expand Up @@ -1093,6 +1093,22 @@ Start of changes for CSD.2

- Add a `conversionSources` property of type `physicalLocation[]`, optional, unique, default: `[]` (logically the same as the old `result.conversionProvenance`).

- [Issue #248](https://github.com/oasis-tcs/sarif-spec/issues/248): "Version control details not strongly associated with results"

In the `versionControlDetails` object:

- Add a `mappedTo` property of type `fileLocation`, optional.

- [Issue #293](https://github.com/oasis-tcs/sarif-spec/issues/293): "Add rule.deprecatedIds"

In the `rule` object:

- Add a `deprecatedIds` property of type `string[]`, optional, `minItems: 0`, `uniqueItems`.

- [Issue #270](https://github.com/oasis-tcs/sarif-spec/issues/270): "Schema needs to be carefully scrubbed for minItems and uniqueItems use for all arrays"

To bring the schema into conformance with this issue, ensure that the attributes of each array-valued property match the [table](https://github.com/oasis-tcs/sarif-spec/issues/270#issuecomment-443353144) in the issue.

## Changes approved but not yet applied to the schema.

- [Issue #256](https://github.com/oasis-tcs/sarif-spec/issues/256): "Make Run.Files an array"
Expand Down Expand Up @@ -1141,22 +1157,6 @@ Start of changes for CSD.2

- Make the `id` property required.

- [Issue #248](https://github.com/oasis-tcs/sarif-spec/issues/248): "Version control details not strongly associated with results"

In the `versionControlDetails` object:

- Add a `mappedTo` property of type `fileLocation`, optional.

- [Issue #293](https://github.com/oasis-tcs/sarif-spec/issues/293): "Add rule.deprecatedIds"

In the `rule` object:

- Add a `deprecatedIds` property of type `string[]`, optional, `minItems: 0`, `uniqueItems`.

- [Issue #270](https://github.com/oasis-tcs/sarif-spec/issues/270): "Schema needs to be carefully scrubbed for minItems and uniqueItems use for all arrays"

To bring the schema into conformance with this issue, ensure that the attributes of each array-valued property match the [table](https://github.com/oasis-tcs/sarif-spec/issues/270#issuecomment-443353144) in the issue.

## Changes not yet approved

- [Issue #202](https://github.com/oasis-tcs/sarif-spec/issues/202): "Restore threadFlowLocation.kind"
Expand Down

0 comments on commit e814d6e

Please sign in to comment.