Skip to content

Commit

Permalink
Fix #66, #74, #81, #88, change-barred
Browse files Browse the repository at this point in the history
  • Loading branch information
Larry Golding committed Feb 19, 2018
1 parent 3246699 commit f1dd776
Show file tree
Hide file tree
Showing 7 changed files with 43 additions and 2 deletions.
Binary file modified Documents/ProvisionalDrafts/sarif-v2.0-wd02-provisional.docx
Binary file not shown.
30 changes: 28 additions & 2 deletions Documents/Schema changes between SARIF v1 and v2.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,28 @@ OASIS SARIF TC).

- `physicalLocation.id`.

- [Issue #66](https://github.com/oasis-tcs/sarif-spec/issues/66): "Enable traceability from converted SARIF file to original analysis tool log file"

Define the `conversion` object with the following properties:

- `tool` of type `tool`, required
- `invocation` of type `invocation`, optional
- `analysisToolLogFileUri` of type string, containing a valid URI, optional
- `analysisToolLogFileUriBaseId` of type string, containing a URI base id, optional

Define the `analysisToolLogFileContents` object with the following properties:

- `region` of type `region`, optional
- `snippet` of type `string`, optional
- `analysisToolLogFileUri` of type string, containing a valid URI, optional
- `analysisToolLogFileUriBaseId` of type string, containing a URI base id, optional

Add the following optional properties:

- `run.conversion` of type `conversion`
- `result.conversionProvenance` of type array of `analysisToolLogFileContents`


- [Issue #69](https://github.com/oasis-tcs/sarif-spec/issues/69): "Provide a physicalLocation on a stack frame"

Remove the following optional properties:
Expand All @@ -72,10 +94,14 @@ OASIS SARIF TC).

Add the following optional property:

- `physicalLocation`
- `stackFrame.physicalLocation`

- [Issue #72](https://github.com/oasis-tcs/sarif-spec/issues/72): "tool.language property needs a default value"

Specify a default value for the following optional property, which subsumes the deleted properties:

- `tool.language`: `"en-US"`
- `tool.language`: `"en-US"`

- [Issue #81](https://github.com/oasis-tcs/sarif-spec/issues/81): "Add 'open' as a result level"

Add an additional enumerated value `"open"` to the `result.level` property.
15 changes: 15 additions & 0 deletions EditorsReports/Editor's report 2018-02-28.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Editor's report

Laurence J. Golding and Michael Fanning

Presented at TC Meeting #11, February 28, 2018

1. After being approved at the last TC meeting (#10), the spec changes for the following issues were merged into the provisional draft:

1. Issue [#66](https://github.com/oasis-tcs/sarif-spec/issues/66): "Enable traceability from converted SARIF file to original analysis tool log file"

2. Issue [#74](https://github.com/oasis-tcs/sarif-spec/issues/74): "Write the "Conformance" section of the spec"

3. Issue [#81](https://github.com/oasis-tcs/sarif-spec/issues/81): "Add 'open' as a result level"

4. Issue [#88](https://github.com/oasis-tcs/sarif-spec/issues/88): "Clarify that missing region indicates a reference to the complete file"

0 comments on commit f1dd776

Please sign in to comment.