-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how converters should provide notifications #15
Comments
Comment from @lgolding: These belong in The message should also make it clear who produced the notification. |
Comment from @lgolding: @michaelcfanning Do you agree that these should be |
Notes from TC con call 2017/09/27:
JimKupsch suggests "provenance" -- tell which native tool output file was converted, and which converter version was used to convert it. Do we want a chain of these? toolNotification could say which numeric index into the provenance array was the source of the notification. |
A tool could merge multiple input reports. A linear chain may be insufficient. |
another possibility is adding converter specific notifications property |
@michaelcfanning I like the idea of a "converter specific notifications property". Now that we have a |
Copied from sarif-standard/sarif-spec-v1#144, created by @michaelcfanning:
Should we provide a way for a converter to communicate that something strange happened during conversion? What about tools that process existing log files and add some notes/observations? Not a breaking change to extend the enum.
The text was updated successfully, but these errors were encountered: