-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Id property renames #159
Comments
@michaelcfanning When we spoke, I agreed with I'm not sold on the |
@michaelcfanning I am going to break this into two issues: This issue is about the property renames, which we agreed to as follows:
I filed a separate issue #165, "Add run.description," for your other suggestion:
|
Note to first-time readers of this issue:
Our thinking about this issue evolved from the time @michaelcfanning first filed it. The gist is that we now understand the distinction between globally unique "instance identifiers" (like the identifier that uniquely identifies the reporting of a result in a specific run) and "logical identifiers" (like the identifier that tells you that this is the x86 variant of the nightly security tools run). We want to define the "instance identifiers" as GUIDs, we want to define the logical identifiers as "hierarchical strings", and we want the property names to make that distinction explicit to the reader of the log file. See my comment below ("I am going to break this into two issues...") to see where we landed.
Original issue description begins here:
today we have run.automationId and run.stableId. first, stableId is a bad name, no other identifier (even when it is a stable one) qualifies the term as such. We seem to be header towards preferring 'correlation' as a clarifying term (see #158).
I propose the we use the following new names:
run.automationCorrelationId
run.correlationId
these should point to descriptor objects with the following properties:
descriptor{
guid -> a guid
id -> the namespaced, human-readable id
description -> readable text that provides mode information on what the described thing is pointing to
}
The text was updated successfully, but these errors were encountered: