Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id property renames #159

Closed
michaelcfanning opened this issue May 4, 2018 · 2 comments
Closed

Id property renames #159

michaelcfanning opened this issue May 4, 2018 · 2 comments

Comments

@michaelcfanning
Copy link
Contributor

michaelcfanning commented May 4, 2018

Note to first-time readers of this issue:

Our thinking about this issue evolved from the time @michaelcfanning first filed it. The gist is that we now understand the distinction between globally unique "instance identifiers" (like the identifier that uniquely identifies the reporting of a result in a specific run) and "logical identifiers" (like the identifier that tells you that this is the x86 variant of the nightly security tools run). We want to define the "instance identifiers" as GUIDs, we want to define the logical identifiers as "hierarchical strings", and we want the property names to make that distinction explicit to the reader of the log file. See my comment below ("I am going to break this into two issues...") to see where we landed.

Original issue description begins here:

today we have run.automationId and run.stableId. first, stableId is a bad name, no other identifier (even when it is a stable one) qualifies the term as such. We seem to be header towards preferring 'correlation' as a clarifying term (see #158).

I propose the we use the following new names:
run.automationCorrelationId
run.correlationId

these should point to descriptor objects with the following properties:

descriptor{
guid -> a guid
id -> the namespaced, human-readable id
description -> readable text that provides mode information on what the described thing is pointing to
}

@ghost
Copy link

ghost commented May 8, 2018

@michaelcfanning When we spoke, I agreed with run.stableId => run.correlationId, but I pushed back on run.automationCorrelationId. The more I think about that one, the more I like it. It's an identifier that correlates the run with something in the automation system. Whereas run.correlationId associates logically similar runs, and result.correlationId associates logically identical results. I'm sold.

I'm not sold on the descriptor object, though. You can see me on it when we talk.

@ghost ghost added enhancement impact-non-breaking-change CSD.1 Will be fixed in CSD.1. labels May 8, 2018
@ghost ghost self-assigned this May 8, 2018
@ghost ghost changed the title consider a descriptor object for documenting the correlating automation and current runs Id property renames May 8, 2018
@ghost
Copy link

ghost commented May 8, 2018

@michaelcfanning I am going to break this into two issues:

This issue is about the property renames, which we agreed to as follows:

I filed a separate issue #165, "Add run.description," for your other suggestion:

  • Add run.description of type message. It's an extended human-readable description of the type of run that run.logicalId identifies.

ghost pushed a commit that referenced this issue May 14, 2018
ghost pushed a commit that referenced this issue May 17, 2018
@ghost ghost closed this as completed May 17, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant