Did we break code flows in v2?

[michaelcfanning]

We should be consulting with GrammaTech on this. We specifically removed a code flow 'kind' and a 'target' property. These two v1 values were useful to GrammaTech previously in order to provide icons and special highlighting/other viewer functionality.

We discussed this yet? The issue is that we have an open-ended 'Kind' string which is intended to be user-facing. Some 'kinds' may arguably be inferable today (such as a call being implied by a change in nesting level) but not necessarily.

I agree with this general concern. I didn't like the proliferation of code flow 'kinds' previously and all the semantics we had to document around matching pairs of them, specifying target contents. But I think it's reasonable to enable viewers to provide standard icons/rendering for certain standard things (like a branch).

[michaelcfanning]

@lgolding this issue is the most urgent in my mind for CSD2. code/thread flows is the most critical part of the format for sophisticated checkers. this scenario needs to be handled very well, otherwise, the analysis that's leading the industry will not derive value from the format.

[ghost]

@michaelcfanning Is there anything left to do here? We have validated that we can display v2 codeFlows in the viewer, and AFAIK the only issue that's been raised is that we need to restore threadFlowLocation.kind (in some manner -- we're still discussing that). That is covered in #202, "Restore threadFlowLocation.kind".

Can we close this? Did Grammatech raise any other issues (I know the "kind" issue didn't come from them.)

[michaelcfanning]

1. remove any requirement to match kind pairs
2. make kind an array of unique elements
3. add sanitizer, source and sink as kinds

make it explicit that nesting level is exclusively used for that concept and doesn't depend on any implied semantics of 'kind'.

[michaelcfanning]

@lgolding, we'll close this and #202 once you have a draft that covers all three points documented above

[michaelcfanning]

@lgolding per a point you made previously, closing this. all open work is tracked in #202