Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define an object type for the value of run.externalPropertyFileReferences #266

Closed
ghost opened this issue Oct 19, 2018 · 0 comments
Closed

Define an object type for the value of run.externalPropertyFileReferences #266

ghost opened this issue Oct 19, 2018 · 0 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug impact-documentation-only merged Changes merged into provisional draft. non-substantive Change falls under editorial discretion resolved-fixed triage-approved

Comments

@ghost
Copy link

ghost commented Oct 19, 2018 •
edited by ghost

The spec says that the value of run.externalPropertyFileReferences is an object, and then it goes on to describe the properties of that object -- but it doesn't give that set of properties a name, unlike every other object in the spec. Define an externalPropertyFileReferences object.

@michaelcfanning FYI.
@ghost ghost added bug impact-documentation-only 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. non-substantive Change falls under editorial discretion labels Oct 19, 2018
@ghost ghost mentioned this issue Oct 19, 2018
Merged
@ghost ghost self-assigned this Nov 7, 2018
@ghost ghost changed the title Define an object type for the value of run.externalFiles Define an object type for the value of run.externalPropertyFileReferences Apr 8, 2019
ghost pushed a commit that referenced this issue Apr 15, 2019
Change draft + merge for #266: externalPropertyFileReferences object.
961d3aa
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed and removed to-be-written labels Apr 15, 2019
@ghost ghost closed this as completed Apr 15, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug impact-documentation-only merged Changes merged into provisional draft. non-substantive Change falls under editorial discretion resolved-fixed triage-approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants