Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run.logicalLocations unique s/be 'true' #304

Closed
michaelcfanning opened this issue Dec 31, 2018 · 0 comments
Closed

run.logicalLocations unique s/be 'true' #304

michaelcfanning opened this issue Dec 31, 2018 · 0 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers resolved-fixed triage-approved

Comments

@michaelcfanning
Copy link
Contributor

There's no good reason to permit duplication of logical locations in this array. run.files and run.resources.rules are also 'true' for this reason.

Note that our classic issue with logical locations (that fully qualified names are duplicated for distinct items) isn't relevant for uniqueness in the array: the 'kind' property will differ for these constructs and differentiate them within the array.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers resolved-fixed triage-approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning