Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider splitting resultlevel into result.level and result.kind #317

Closed
michaelcfanning opened this issue Jan 25, 2019 · 6 comments
Closed

Consider splitting resultlevel into result.level and result.kind #317

michaelcfanning opened this issue Jan 25, 2019 · 6 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers p1 Priority 1 issue to close resolved-fixed

Comments

@michaelcfanning
Copy link
Contributor

Starting proposal:

resultKind -> open, review, not applicable, pass, fail

messageLevel -> note, warning, error

This allows us to converge notification and result levels so, hence, message level.
@michaelcfanning michaelcfanning added the p1 Priority 1 issue to close label Jan 25, 2019
@michaelcfanning
Copy link
Contributor Author

TC approves this change.

@michaelcfanning michaelcfanning added the design-approved The TC approved the design and I can write the change draft label Jan 25, 2019
@michaelcfanning michaelcfanning mentioned this issue Jan 25, 2019
Closed
@michaelcfanning
Copy link
Contributor Author

@lgolding, schema change is ready for this. is it ok to mark these as 'to-be;written'?

@ghost
Copy link

ghost commented Feb 11, 2019

@michaelcfanning Yes.

ghost pushed a commit that referenced this issue Feb 18, 2019
Change draft for #317: result.kind/level.
37b1ff1
@ghost ghost self-assigned this Feb 18, 2019
@michaelcfanning
Copy link
Contributor Author

Update, we have added level.none and kind.debug.

@ghost ghost mentioned this issue Feb 20, 2019
Closed
ghost pushed a commit that referenced this issue Feb 21, 2019
Merge #317: result.kind/result.level
d7f725d
@ghost
Copy link

ghost commented Feb 21, 2019

@michaelcfanning I emailed pushing back on kind.debug.

@ghost
Copy link

ghost commented Feb 21, 2019

Changes merged to provisional draft.

@ghost ghost closed this as completed Feb 21, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers p1 Priority 1 issue to close resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning