Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow toolComponents to be externalized #337

Closed
michaelcfanning opened this issue Mar 1, 2019 · 2 comments
Closed

Allow toolComponents to be externalized #337

michaelcfanning opened this issue Mar 1, 2019 · 2 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement e-ballot-3 impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed tc-33 Issues to present at SARIF TC33

Comments

@michaelcfanning
Copy link
Contributor

michaelcfanning commented Mar 1, 2019 •
edited

The proposal here is to add "driver" and "extensions" (an array) to run.externalPropertyFiles. These special properties are used to persist the driver and extensions from the current run.
@michaelcfanning michaelcfanning added the tc-33 Issues to present at SARIF TC33 label Mar 7, 2019
@ghost ghost changed the title Extensions metadata is not externalizable in a granular way Allow toolComponents to be externalized Mar 7, 2019
@ghost ghost added impact-non-breaking-change 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-improvement design-approved The TC approved the design and I can write the change draft labels Mar 15, 2019
@ghost
Copy link

ghost commented Mar 15, 2019

Approved at TC 33.

ghost pushed a commit that referenced this issue Mar 18, 2019
Change draft + merge fpr #337: externalize toolComponent
3e0d93d
@ghost ghost added change-draft-available merged Changes merged into provisional draft. labels Mar 18, 2019
ghost pushed a commit that referenced this issue Mar 19, 2019
#337: Rework and fix names of externalized driver and extensions.
eed8362
ghost pushed a commit that referenced this issue Mar 19, 2019
#337: More cleanup.
ca1eab6
ghost pushed a commit that referenced this issue Mar 19, 2019
#337: One more tweak.
7b2c216
@ghost ghost self-assigned this Apr 6, 2019
@ghost
Copy link

ghost commented Apr 6, 2019

Approved in e-ballot-3.

@ghost ghost closed this as completed Apr 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement e-ballot-3 impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed tc-33 Issues to present at SARIF TC33
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning