Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'reportingDescriptor.deprecatedNames' and 'deprecatedGuids' to match 'deprecatedIds' property #346

Closed
michaelcfanning opened this issue Mar 24, 2019 · 1 comment
Closed

Add 'reportingDescriptor.deprecatedNames' and 'deprecatedGuids' to match 'deprecatedIds' property #346

michaelcfanning opened this issue Mar 24, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. domain-result-management e-ballot-3 enhancement impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed tc-34

Comments

@michaelcfanning
Copy link
Contributor

michaelcfanning commented Mar 24, 2019 •
edited by ghost

E-BALLOT #3 PROPOSAL

To track rules evolution, the property reportingDescriptor.deprecatedIds tracks updates to a check's stable and opaque id property. We should also track changes to its readable name and its GUID.

SCHEMA CHANGES

  • In the reportingDescriptor property:

    • Add a property deprecatedNames of type string[], optional: names by which this rule or notification was previously known.
    • Add a property deprecatedGuids of type string[], optional: GUIDs by which this rule or notification was previously identified.
@ghost ghost self-assigned this Mar 25, 2019
@ghost ghost changed the title Add 'reportingDescriptor.deprecatedNames' to match 'deprecatedIds' property Add 'reportingDescriptor.deprecatedNames' and 'deprecatedGuids' to match 'deprecatedIds' property Mar 25, 2019
ghost pushed a commit that referenced this issue Mar 25, 2019
Change draft + merge for #346: deprecated{Names,Guids}
9536f8a
@ghost ghost added change-draft-available merged Changes merged into provisional draft. and removed to-be-written labels Mar 25, 2019
@ghost
Copy link

ghost commented Apr 6, 2019

Approved in e-ballot-3.

@ghost ghost closed this as completed Apr 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. domain-result-management e-ballot-3 enhancement impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed tc-34
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning