Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reportingConfigurationOverride to configurationOverride #350

Closed
ghost opened this issue Mar 29, 2019 · 1 comment
Closed

Rename reportingConfigurationOverride to configurationOverride #350

ghost opened this issue Mar 29, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. e-ballot-3 impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented Mar 29, 2019 •
edited by ghost
Loading

E-BALLOT #3 PROPOSAL

Rename reportingConfigurationOverride to configurationOverride. This is part of our end-game naming simplification push. The word "reporting" adds nothing. Rename the internal property that refers to the relevant reportingDescriptorReference to descriptor.

SCHEMA CHANGES

  • Rename the reportingConfigurationOverride object to configurationOverride.
  • Rename configurationOverride.reportingDescriptorReference to configurationOverride.descriptor

NOTES

  • There will be no change draft because these are simple renames.
@ghost ghost added impact-breaks-consumers impact-breaks-producers 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. to-be-written change-draft-superfluous The change is a simple rename; no change draft needed. e-ballot-3 labels Mar 29, 2019
@ghost ghost self-assigned this Mar 29, 2019
@ghost ghost removed the to-be-written label Mar 29, 2019
ghost pushed a commit that referenced this issue Mar 29, 2019
#350: reportingConfigurationOverride => configurationOverride (no cha…
8ee52cd 
…nge draft).
@ghost ghost added the merged Changes merged into provisional draft. label Mar 29, 2019
ghost pushed a commit that referenced this issue Mar 29, 2019
#350 rename configOverride.rptDescRef => descriptor.
b00d75a
@ghost ghost added resolved-fixed and removed change-draft-superfluous The change is a simple rename; no change draft needed. labels Apr 6, 2019
@ghost
Copy link
Author

ghost commented Apr 6, 2019

Approved in e-ballot-3.

@ghost ghost closed this as completed Apr 6, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. e-ballot-3 impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants