Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing rename: message.messageId => message.id #352

Closed
ghost opened this issue Apr 1, 2019 · 1 comment
Closed

Missing rename: message.messageId => message.id #352

ghost opened this issue Apr 1, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. required resolved-fixed tc-34

Comments

@ghost
Copy link

ghost commented Apr 1, 2019

This rename should have been obvious to me when I removed message.richMessageId, leaving only messageId behind, but I missed it.
@ghost ghost added bug 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. change-draft-superfluous The change is a simple rename; no change draft needed. tc-34 labels Apr 1, 2019
@ghost ghost self-assigned this Apr 1, 2019
@ghost ghost added the required label Apr 1, 2019
ghost pushed a commit that referenced this issue Apr 1, 2019
Agenda: Add #352, message.messageId => message.id
b535aa5
@ghost ghost added design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed and removed change-draft-superfluous The change is a simple rename; no change draft needed. labels Apr 3, 2019
@ghost
Copy link
Author

ghost commented Apr 3, 2019

Approved at TC #34, already in provisional draft, closing.

@ghost ghost closed this as completed Apr 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. bug design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. required resolved-fixed tc-34
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants