Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punch list #353

Closed
4 tasks done
ghost opened this issue Apr 2, 2019 · 1 comment
Closed
4 tasks done

Punch list #353

ghost opened this issue Apr 2, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-34

Comments

@ghost
Copy link

ghost commented Apr 2, 2019 •
edited by ghost

This is an issue to hold a set of small, hopefully non-controversial issues that shouldn't require independent substantive discussion:

  • Properties address.{baseAddress,offset} are of type integer, not string.
  • physicalLocation.artifactLocation can no longer be required because the location might be specified only by an address. Instead, anyOf artifactLocation and address is required.
  • Add new address.kind value "module".
  • In rule.taxa[i] and rule.optionalTaxa[i], if the taxon's toolComponent property is absent, it SHALL default to the taxonomy at index 0 in theRun.taxonomies. This optimizes the happy path where only one taxonomy is in use.
@ghost ghost added change-draft-superfluous The change is a simple rename; no change draft needed. 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. discussion-ongoing impact-non-breaking-change tc-34 labels Apr 2, 2019
ghost pushed a commit that referenced this issue Apr 3, 2019
Change draft for #353: punch list.
5f96a76
@ghost ghost added change-draft-available and removed change-draft-superfluous The change is a simple rename; no change draft needed. labels Apr 3, 2019
@ghost ghost self-assigned this Apr 3, 2019
ghost pushed a commit that referenced this issue Apr 3, 2019
Change draft for #353: Punch list.
971ce7a
ghost pushed a commit that referenced this issue Apr 3, 2019
Merge #353: punch list.
300155e
ghost pushed a commit that referenced this issue Apr 3, 2019
#353: Fix typos in change draft (already corrected in provisional).
1767e3c
@ghost
Copy link
Author

ghost commented Apr 3, 2019

Change draft written; merged into provisional draft; closing.

@ghost ghost closed this as completed Apr 3, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft design-improvement impact-breaks-consumers impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed tc-34
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants