Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more address kinds #397

Closed
ghost opened this issue Apr 25, 2019 · 4 comments
Closed

Add more address kinds #397

ghost opened this issue Apr 25, 2019 · 4 comments
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. enhancement impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed

Comments

@ghost
Copy link

ghost commented Apr 25, 2019

We need address.kind values "instruction" and "data".
@ghost ghost added enhancement impact-non-breaking-change 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. schema-todo labels Apr 25, 2019
@ghost ghost self-assigned this Apr 25, 2019
@ghost
Copy link
Author

ghost commented Apr 25, 2019

@michaelcfanning I am changing it to "instructions" because an "address" object has a length, so it might specify a whole sequence of instructions. "data" doesn't have that problem (because I didn't start out calling it "datum" 😄).

@ghost
Copy link
Author

ghost commented Apr 25, 2019

Ok, I'm wrong: address does not have a length. But address objects occur in physicalLocation objects, and physicalLocation.region does have a length (byteLength). So it might still be appropriate to name the new value "instructions" rather than "instruction".

@michaelcfanning Please make the call.

@ghost
Copy link
Author

ghost commented Apr 25, 2019

@michaelcfanning says: "instruction" because designating an "instruction pointer" is the happy path.

ghost pushed a commit that referenced this issue Apr 26, 2019
Change draft + merge for #397: Add more address kinds.
6b56d71
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed labels Apr 26, 2019
@ghost ghost closed this as completed Apr 26, 2019
ghost pushed a commit that referenced this issue Apr 26, 2019
#397: Rename invocation.toolExecutionSuccessful to executionSuccessful
c36d6d8
@ghost ghost removed the schema-todo label Apr 29, 2019
@ghost
Copy link
Author

ghost commented Apr 29, 2019

I confirm that this change is correctly in the schema.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. enhancement impact-non-breaking-change merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants