Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve spec vs. schema discrepancy re: "language" property #402

Closed
michaelcfanning opened this issue Apr 27, 2019 · 1 comment
Closed

Resolve spec vs. schema discrepancy re: "language" property #402

michaelcfanning opened this issue Apr 27, 2019 · 1 comment
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed

Comments

@michaelcfanning
Copy link
Contributor

The spec mandates RFC5646 to populate run.language. The schema specifies that this property is constrained to a proper subset of RFC5646, consisting of an ISO 639-1 country code and an optional ISO 3166 region code.

Larry and I can't locate any history that helps us figure out how this discrepancy materialized. The RFC5646 requirement is long-standing (in fact, dates back to SARIF v1). The most likely scenarios are that we either changed the requirement and failed to update the spec. Or that we updated the schema speculatively in the SDK and someone made a successful case against the change in TC discussion.

Does anyone recall the history on this? @kupsch?
@ghost
Copy link

ghost commented Apr 29, 2019

Per @kupsch: ISO 639-1/ISO 3166 suffices.

@ghost ghost self-assigned this Apr 29, 2019
@ghost ghost added 2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft impact-breaks-producers labels Apr 29, 2019
ghost pushed a commit that referenced this issue Apr 29, 2019
Change draft + merge for #402: Restrict languages to ISO 639-1/ISO 3166
a2bcb31
@ghost ghost added merged Changes merged into provisional draft. resolved-fixed labels Apr 29, 2019
@ghost ghost closed this as completed Apr 29, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-CSD.1 Will be fixed in SARIF v2.1.0 CSD.1. design-approved The TC approved the design and I can write the change draft impact-breaks-producers merged Changes merged into provisional draft. resolved-fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelcfanning