Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comprehensive SARIF file example is not a valid JSON. #476

Closed
dector opened this issue Sep 6, 2020 · 3 comments
Closed

Comprehensive SARIF file example is not a valid JSON. #476

dector opened this issue Sep 6, 2020 · 3 comments
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft impact-documentation-only ready

Comments

@dector
Copy link

dector commented Sep 6, 2020

Example provided in K.4 section is not a valid JSON file (numerous error are found). Also there are some fields that are not defined in schema (e.g. runs.automationId).

Thus, according to SARIF Validator this example is not a valid SARIF file.
@dector dector mentioned this issue Sep 8, 2020
Closed
@ghost
Copy link

ghost commented Sep 16, 2020

Thanks @dector for finding the errors.

@michaelcfanning michaelcfanning added the design-approved The TC approved the design and I can write the change draft label Aug 12, 2021
@michaelcfanning
Copy link
Contributor

Fixing this was approved during TC session 42.

@michaelcfanning michaelcfanning changed the title Comprehensive SARIF file example is not a valid JSON Comprehensive SARIF file example is not a valid JSON. Nov 8, 2021
@dmk42 dmk42 mentioned this issue Apr 21, 2022
Closed
5 tasks
@indietyp indietyp mentioned this issue Mar 22, 2023
Merged
@dmk42
Copy link
Contributor

dmk42 commented Dec 19, 2023

Now that the Errata document has been published, this has been fixed in the official version of the standard.

@dmk42 dmk42 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.1.0-erratum design-approved The TC approved the design and I can write the change draft impact-documentation-only ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dector @michaelcfanning @dmk42