Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example SARIF files as test data #2252

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add example SARIF files as test data #2252

merged 1 commit into from
Mar 22, 2023

Conversation

TimDiekmann
Copy link
Member

@TimDiekmann TimDiekmann commented Mar 21, 2023

🌟 What is the purpose of this PR?

The specifications have four examples SARIF files as an appendix. This PR pulls them into VCS to test the current implementation for those examples.

🔗 Related links

⚠️ Known issues

  • For Example K4 I had to fix some line endings, e.g. a trailing comma or a missing brace
  • The JSON Schema validator complains at some sections in K4

@TimDiekmann TimDiekmann requested a review from a team as a code owner March 21, 2023 22:28
@github-actions github-actions bot added the area/libs > sarif Affects the `sarif` crate (library) label Mar 21, 2023
@github-advanced-security
Copy link

You have successfully added a new Semgrep configuration .github/workflows/semgrep.yml:semgrep. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new clippy configuration sarif. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

libs/sarif/src/schema.rs Fixed Show fixed Hide fixed
libs/sarif/src/schema.rs Fixed Show fixed Hide fixed
libs/sarif/src/schema.rs Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #2252 (1b5833f) into main (d7da594) will increase coverage by 0.44%.
The diff coverage is 100.00%.

❗ Current head 1b5833f differs from pull request most recent head db38de8. Consider uploading reports for the commit db38de8 to get more accurate results

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
+ Coverage   60.71%   61.16%   +0.44%     
==========================================
  Files         295      296       +1     
  Lines       22703    22966     +263     
  Branches      420      420              
==========================================
+ Hits        13784    14047     +263     
  Misses       8914     8914              
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/sarif/src/lib.rs 100.00% <ø> (ø)
libs/sarif/src/schema.rs 100.00% <ø> (ø)
libs/sarif/src/schema/log.rs 100.00% <100.00%> (ø)
libs/sarif/src/schema/properties.rs 100.00% <100.00%> (ø)
libs/sarif/src/schema/run.rs 100.00% <100.00%> (ø)
libs/sarif/src/schema/tool.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vilkinsons vilkinsons changed the title Add example serif files as test data Add example SARIF files as test data Mar 21, 2023
indietyp
indietyp previously approved these changes Mar 22, 2023
Copy link
Member

@indietyp indietyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad to see that K4 is broken, the issue seems to be semi-activively and discussed and the following errata will change the json-schema to make it comply more with the spec.

Base automatically changed from td/sarif/basic-types to main March 22, 2023 09:42
@TimDiekmann
Copy link
Member Author

Thanks for posting the link!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > sarif Affects the `sarif` crate (library)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants