Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split individual virtio device spec to its own file #153

Closed
paravmellanox opened this issue Dec 24, 2022 · 5 comments
Closed

Split individual virtio device spec to its own file #153

paravmellanox opened this issue Dec 24, 2022 · 5 comments
Labels
virtio-v1.3-cs01

Comments

@paravmellanox
Copy link
Contributor

paravmellanox commented Dec 24, 2022 •
edited

Problem statement:
Relatively several of the recent device specification are maintained in their own specification file.
Such separate files enables better maintenance of the specification overall.

However, several of the initial virtio device specifications are located in single file. Current specification is maintained as mixed mode.

Solution:
Hence follow the modular approach practice of individual files for all devices.

Patches: https://lists.oasis-open.org/archives/virtio-dev/202301/msg00210.html
@paravmellanox
Copy link
Contributor Author

@mstsirkin ,

Can we please start the vote on it if it is needed?

As you know,
Patches do not change any part of the specification outcome
except fixing the spelling errors.
It only changes how the specification is maintained.

@mstsirkin
Copy link
Contributor

mstsirkin commented Jan 3, 2023 •
edited

BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3746

Ballot was retracted

@paravmellanox
Copy link
Contributor Author

@mstsirkin ,
link to the v3 is updated now in the description.

@paravmellanox
Copy link
Contributor Author

@mstsirkin
link to v4 is updated now in the description.

@mstsirkin
Copy link
Contributor

BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3748

@cohuck cohuck closed this as completed in f2b2869 Jan 30, 2023
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-blk: Maintain block device spec in separate directory
335342f 
Move virtio block device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-console: Maintain console device spec in separate directory
d3d0618 
Move virtio console device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-entropy: Maintain entropy device spec in separate directory
c71e88e 
Move virtio entropy device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-balloon: Maintain mem balloon device spec in separate directory
c06f3b6 
Move virtio memory balloon device specification to its own file
similar to recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-scsi: Maintain scsi host device spec in separate directory
d404f1c 
Move virtio SCSI host device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-gpu: Maintain gpu device spec in separate directory
442bb64 
Move virtio gpu device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-input: Maintain input device spec in separate directory
c9686f2 
Move virtio input device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-crypto: Maintain crypto device spec in separate directory
8463bba 
Move virtio crypto device specification to its own file similar to
recent virtio devices.
While at it, place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-vsock: Maintain socket device spec in separate directory
828754b 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-fs: Maintain file system device spec in separate directory
8632f80 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-rpmb: Maintain rpmb device spec in separate directory
b067de4 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-iommu: Maintain iommu device spec in separate directory
b1cf73e 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-sound: Maintain sound device spec in separate directory
6813e3c 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-mem: Maintain memory device spec in separate directory
5042a50 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-i2c: Maintain i2c device spec in separate directory
00b9935 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-scmi: Maintain scmi device spec in separate directory
674489b 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-gpio: Maintain gpio device spec in separate directory
6c9c04d 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
cohuck pushed a commit that referenced this issue Jan 30, 2023
@paravmellanox @cohuck
virtio-pmem: Maintain pmem device spec in separate directory
d04d253 
Place device specification, its driver and device
conformance into its own directory to have self contained device
specification.

Fixes: #153

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
virtio-v1.3-cs01
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstsirkin @paravmellanox