Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio-net: Mention that VIRTIO_NET_F_HASH_REPORT requires VIRTIO_NET_F_CTRL_VQ. #158

Closed
Alvaro-Karsz opened this issue Feb 5, 2023 · 3 comments

Comments

@Alvaro-Karsz
Copy link
Contributor

Alvaro-Karsz commented Feb 5, 2023

If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
is needed.

Since this was missed in 1.2, we can now add it as a "SHOULD".

https://lists.oasis-open.org/archives/virtio-comment/202302/msg00031.html

@mstsirkin
Copy link
Contributor

unfortunately in 1.2 we already did not make this a dependency.
so we can make it a SHOULD since it makes sense, but not a MUST
without a feature bit.

@Alvaro-Karsz
Copy link
Contributor Author

Ok, I'll fix the github issue and the patch.

@mstsirkin
Copy link
Contributor

BALLOT CREATED AT URL: https://www.oasis-open.org/committees/ballot.php?id=3755

@cohuck cohuck closed this as completed in 2ea4627 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants