Skip to content

Commit

Permalink
virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET…
Browse files Browse the repository at this point in the history
…_F_CTRL_VQ

If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may
send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ
feature should be negotiated.

Fixes: #158
Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
  • Loading branch information
Alvaro-Karsz authored and cohuck committed Feb 20, 2023
1 parent be2ce1e commit 2ea4627
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions device-types/net/description.tex
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
\field{duplex} fields as long as VIRTIO_NET_S_LINK_UP is set in
the \field{status}.

The device SHOULD NOT offer VIRTIO_NET_F_HASH_REPORT if it
does not offer VIRTIO_NET_F_CTRL_VQ.

\drivernormative{\subsubsection}{Device configuration layout}{Device Types / Network Device / Device configuration layout}

A driver SHOULD negotiate VIRTIO_NET_F_MAC if the device offers it.
Expand Down Expand Up @@ -289,6 +292,9 @@ \subsection{Device configuration layout}\label{sec:Device Types / Network Device
SHOULD re-read \field{speed} and \field{duplex} after a
configuration change notification.

A driver SHOULD NOT negotiate VIRTIO_NET_F_HASH_REPORT if it
does not negotiate VIRTIO_NET_F_CTRL_VQ.

\subsubsection{Legacy Interface: Device configuration layout}\label{sec:Device Types / Network Device / Device configuration layout / Legacy Interface: Device configuration layout}
\label{sec:Device Types / Block Device / Feature bits / Device configuration layout / Legacy Interface: Device configuration layout}
When using the legacy interface, transitional devices and drivers
Expand Down

0 comments on commit 2ea4627

Please sign in to comment.