Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XLIFF 2.1 - Example in 4.3.1.40 type is invalid #10

Closed
yumaoka opened this issue Aug 23, 2021 · 3 comments
Closed

XLIFF 2.1 - Example in 4.3.1.40 type is invalid #10

yumaoka opened this issue Aug 23, 2021 · 3 comments
Labels

Comments

@yumaoka
Copy link
Contributor

yumaoka commented Aug 23, 2021

<segment>
  <source xml:lang="cs"><pc type="quote">Blázen,
      chce dobýt točnu v takovém počasí</pc>, dodal slovy svého
      oblíbeného imaginárního autora.</source>
  <target xml:lang="en"><pc type="quote">Madman, he wants to conquer the
      pole in this weather</pc>, offered he the words of his
      favourite imaginary playwright.</target>
</segment>

The example above illustrates the use of type="quote" with <pc> element. The id attribute is required in each <pc> element, but the example is missing the attribute.

In addition to this, I personally don't like to put xml:lang attribute in this example. I think the original author's intent was to clarify what is source/target language in this example. But even without it, it should be sufficient to illustrate the use of type="quote" with <pc> element.

@DavidFatDavidF
Copy link
Contributor

agreed to add id attributes in the pc elements, I would keep the xml:lang

@rmraya
Copy link
Contributor

rmraya commented Dec 11, 2021

Fixed in current draft

@DavidFatDavidF
Copy link
Contributor

Check if the xml:lang was kept

@DavidFatDavidF DavidFatDavidF added the fixed fixed label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants