Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/common/identity: Use Ed25519 instead of P-256 for TLS certs #2058

Closed
Yawning opened this issue Sep 4, 2019 · 2 comments · Fixed by #2600
Closed

go/common/identity: Use Ed25519 instead of P-256 for TLS certs #2058

Yawning opened this issue Sep 4, 2019 · 2 comments · Fixed by #2600
Labels
c:common Category: common libraries golang s:good first issue Status: good for newcomers

Comments

@Yawning
Copy link
Contributor

Yawning commented Sep 4, 2019

We use P-256 for the TLS cert signing key. Since Go 1.13 supports it, we could switch that to Ed25519. That said, I don't have anything against P-256 at this moment, and it would only be for consistency.
@Yawning Yawning added s:good first issue Status: good for newcomers c:common Category: common libraries golang labels Sep 4, 2019
@Yawning
Copy link
Contributor Author

Yawning commented Nov 6, 2019

There's no real reason to do this.

@Yawning Yawning closed this as completed Nov 6, 2019
@Yawning
Copy link
Contributor Author

Yawning commented Jan 27, 2020

In retrospect, there is a reason to do this (#2599).

@Yawning Yawning reopened this Jan 27, 2020
@Yawning Yawning mentioned this issue Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:common Category: common libraries golang s:good first issue Status: good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

registry: bug fixes oasisprotocol/oasis-core
1 participant
@Yawning