This repository has been archived by the owner on Oct 22, 2023. It is now read-only.
CI: Build in a shared target dir #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pro-wh
commented
Apr 20, 2018
.circleci/config.yml
Outdated
| ekiden-key-manager | ||
| # Build the contract. | ||
| - run: cargo ekiden build-contract --output-identity | ||
| # Run the contract tests. | ||
| - run: cargo test | ||
| # Build the client. | ||
| - run: | ||
| command: cargo build | ||
| command: CARGO_BUILD_TARGET_DIR=../target cargo build |
There was a problem hiding this comment.
maybe move this to the client Cargo.toml file.
maybe just make this whole repo a workspace, even
pro-wh
force-pushed
the
targetpath
branch
3 times, most recently
from
8479509
to
9b37a21
Compare
pro-wh
force-pushed
the
targetpath
branch
2 times, most recently
from
6235a98
to
5bf9438
Compare
|
yup that's temporary |
|
broken on alpha.4 incompatibility |
|
Once oasisprotocol/oasis-core#172 is merged, we can tag alpha.5 and revisit. |
pro-wh
commented
May 10, 2018
| # Build the contract. | ||
| - run: cargo ekiden build-contract --output-identity | ||
| # Run the contract tests. | ||
| - run: cargo test | ||
| # Build the client. | ||
| - run: | ||
| command: cargo build | ||
| environment: | ||
| CARGO_BUILD_TARGET_DIR: ../target |
There was a problem hiding this comment.
rust-lang/cargo#1657
CARGO_TARGET_DIR works too, and I think that one is better documented
peterjgilbert
approved these changes
May 15, 2018
.circleci/config.yml
Outdated
| @@ -87,7 +106,8 @@ workflows: | |||
| - deploy: | |||
| filters: | |||
| branches: | |||
| only: master | |||
| # %%% change back to master | |||
There was a problem hiding this comment.
reminder to change back to master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the build commands in CI to use a shared target dir. Also install programs in debug mode to further share compiled libraries. Reduces build time from ~15 min to ~8 min. Deploy time goes from ~13 min to ~10 min.
fixes #2
depends: oasisprotocol/oasis-core#168
tasks before merge:
tagged versions (can be done already with alpha.4)master branch