Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -y flag to oasis wallet remove #217

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add -y flag to oasis wallet remove #217

merged 1 commit into from
Apr 18, 2024

Conversation

amela
Copy link
Member

@amela amela commented Apr 5, 2024

No description provided.

@amela amela linked an issue Apr 5, 2024 that may be closed by this pull request
Add -y flag to oasis wallet remove #120
Closed
@amela amela changed the title wallet: Add -y flag to oasis wallet remove Add -y flag to oasis wallet remove Apr 5, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 5, 2024 •
edited
Loading

✅ Deploy Preview for oasisprotocol-cli canceled.

Name Link
🔨 Latest commit 5d6ac39
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-cli/deploys/6620dada1e89ce000804022f

@amela amela force-pushed the amela/add-y-flag-to-oasis-wallet-remove branch from b1b3e94 to 0e0fb40 Compare April 5, 2024 09:55
@amela amela requested a review from matevz April 5, 2024 10:02
@amela amela force-pushed the amela/add-y-flag-to-oasis-wallet-remove branch from 0e0fb40 to 007187e Compare April 5, 2024 10:11
matevz
matevz requested changes Apr 5, 2024
View reviewed changes
cmd/wallet/remove.go Outdated Show resolved Hide resolved
@amela amela force-pushed the amela/add-y-flag-to-oasis-wallet-remove branch 3 times, most recently from ff7b70e to a145296 Compare April 5, 2024 12:48
@amela amela marked this pull request as ready for review April 5, 2024 12:53
@amela amela requested a review from matevz April 8, 2024 15:26
matevz
matevz requested changes Apr 8, 2024
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to clean the common/transactions.go to use the new common AnswerYes flag.

@amela amela force-pushed the amela/add-y-flag-to-oasis-wallet-remove branch 3 times, most recently from c84b2f4 to 8ebb821 Compare April 18, 2024 08:01
@amela amela requested review from matevz and kostko April 18, 2024 08:04
@amela amela force-pushed the amela/add-y-flag-to-oasis-wallet-remove branch from 8ebb821 to 5d6ac39 Compare April 18, 2024 08:33
@amela amela merged commit 44d1e14 into master Apr 18, 2024
4 checks passed
@amela amela deleted the amela/add-y-flag-to-oasis-wallet-remove branch April 18, 2024 08:35
@amela amela mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

@kostko kostko Awaiting requested review from kostko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -y flag to oasis wallet remove
2 participants
@amela @matevz