feat(cmd): Add support for registry operations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/registry-unfreezenode
branch
2 times, most recently
from
51f62dd
to
7fc47e9
Compare
matevz
requested changes
Mar 29, 2023
|
Node registration happens automatically by oasis-node so manual registration should never be needed. Good point about the registry inspect functions. By dump you probably mean something like the current |
kostko
force-pushed
the
kostko/feature/registry-unfreezenode
branch
from
7fc47e9
to
baf2c9a
Compare
|
Moved the |
matevz
approved these changes
Mar 30, 2023
| cobra.CheckErr("account does not support signing consensus transactions") | ||
| } | ||
| if !signer.Public().Equal(descriptor.ID) { | ||
| cobra.CheckErr(fmt.Errorf("entity ID (%s) does not correspond to selected account (%s)", |
There was a problem hiding this comment.
Suggested change
| cobra.CheckErr(fmt.Errorf("entity ID (%s) does not correspond to selected account (%s)", | |
| cobra.CheckErr(fmt.Errorf("entity ID '%s' does not correspond to selected account '%s' (%s)", |
| } | ||
| if !signer.Public().Equal(descriptor.ID) { | ||
| cobra.CheckErr(fmt.Errorf("entity ID (%s) does not correspond to selected account (%s)", | ||
| descriptor.ID, signer.Public())) |
There was a problem hiding this comment.
Suggested change
| descriptor.ID, signer.Public())) | |
| descriptor.ID, npa.AccountName, signer.Public())) |
| acc := common.LoadAccount(cfg, npa.AccountName) | ||
| signer := acc.ConsensusSigner() | ||
| if signer == nil { | ||
| cobra.CheckErr("account does not support signing consensus transactions") |
There was a problem hiding this comment.
Suggested change
| cobra.CheckErr("account does not support signing consensus transactions") | |
| cobra.CheckErr(fmt.Errorf("account '%s' does not support signing consensus transactions", npa.AccountName)) |
| tx := registry.NewDeregisterEntityTx(0, nil) | ||
|
|
||
| acc := common.LoadAccount(cfg, npa.AccountName) | ||
| sigTx, err := common.SignConsensusTransaction(ctx, npa, acc, conn, tx) |
There was a problem hiding this comment.
It would be nice if PrettyPrinter omitted the
Body:
{}
chunk if Body is empty. But this needs to be fixed in SDK.
| registryRuntimeRegisterCmd.Flags().AddFlagSet(common.SelectorFlags) | ||
| registryRuntimeRegisterCmd.Flags().AddFlagSet(common.TransactionFlags) | ||
|
|
||
| registryShowCmd.Flags().AddFlagSet(common.SelectorFlags) |
There was a problem hiding this comment.
oasis registry show only requires --network flag afaik.
|
Ah, crap, automerge was enabled. Can you make a short followup? |
|
Yeah will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.