Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor network, paratime and account commands #75

Merged
merged 8 commits into from May 18, 2023

Conversation

matevz
Copy link
Member

@matevz matevz commented May 16, 2023

Implements #73 .

Also:

  • splits account.go into account/ folder containing file for each subcommand
  • splits network.go into network/ folder containing file for each subcommand
  • splits paratime.go into paratime/ folder containing file for each subcommand
  • adds gas costs and debonding interval to network info
  • adds selectors for network-only and network-account-only
  • splits TransactionFlags to TxFlags and RuntimeTxFlags (e.g. only runtimes support --encrypted flag and may give false sense of security to the user for consensus transactions)
  • fixes regression introduced in feat(cmd): Add support for outputting unsigned transactions #67 in contract command if --unsigned used
  • adds shorthand aliases for root commands
  • number of stylistic changes in the UI (paratime -> ParaTime, consistent === TITLES ===)

@matevz matevz self-assigned this May 16, 2023
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch from 67d9e13 to 39f3fb6 Compare May 16, 2023 12:47
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments, haven't reviewed everything yet.

cmd/account/entity.go Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch 2 times, most recently from e799223 to a77ae42 Compare May 17, 2023 09:39
cmd/account/transfer.go Outdated Show resolved Hide resolved
cmd/account/entity.go Outdated Show resolved Hide resolved
cmd/account/entity.go Outdated Show resolved Hide resolved
cmd/paratime/register.go Outdated Show resolved Hide resolved
cmd/paratime/register.go Outdated Show resolved Hide resolved
cmd/paratime/stats.go Outdated Show resolved Hide resolved
cmd/paratime/show.go Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch 2 times, most recently from 5aa65ee to be78497 Compare May 17, 2023 12:14
cmd/common/transaction.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch 2 times, most recently from 5e808ac to 97a55f2 Compare May 17, 2023 14:37
cmd/common/transaction.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch from 97a55f2 to 751897d Compare May 18, 2023 09:29
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch 2 times, most recently from 679165a to 79728b9 Compare May 18, 2023 10:01
@matevz matevz force-pushed the matevz/feature/refactor-net-pt-acc-cmds branch from 79728b9 to 3efe065 Compare May 18, 2023 10:04
@matevz matevz merged commit 635e9dc into master May 18, 2023
2 checks passed
@matevz matevz deleted the matevz/feature/refactor-net-pt-acc-cmds branch May 18, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants