New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor network, paratime and account commands #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
from
May 16, 2023 12:47
67d9e13
to
39f3fb6
Compare
kostko
reviewed
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial comments, haven't reviewed everything yet.
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
2 times, most recently
from
May 17, 2023 09:39
e799223
to
a77ae42
Compare
kostko
reviewed
May 17, 2023
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
2 times, most recently
from
May 17, 2023 12:14
5aa65ee
to
be78497
Compare
kostko
reviewed
May 17, 2023
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
2 times, most recently
from
May 17, 2023 14:37
5e808ac
to
97a55f2
Compare
kostko
reviewed
May 17, 2023
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
from
May 18, 2023 09:29
97a55f2
to
751897d
Compare
kostko
approved these changes
May 18, 2023
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
2 times, most recently
from
May 18, 2023 10:01
679165a
to
79728b9
Compare
matevz
force-pushed
the
matevz/feature/refactor-net-pt-acc-cmds
branch
from
May 18, 2023 10:04
79728b9
to
3efe065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #73 .
Also:
account.go
intoaccount/
folder containing file for each subcommandnetwork.go
intonetwork/
folder containing file for each subcommandparatime.go
intoparatime/
folder containing file for each subcommandnetwork info
TransactionFlags
toTxFlags
andRuntimeTxFlags
(e.g. only runtimes support--encrypted
flag and may give false sense of security to the user for consensus transactions)contract
command if--unsigned
used