Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): Oasis paratime statistics fixes #80

Merged
merged 2 commits into from May 30, 2023
Merged

Conversation

matevz
Copy link
Member

@matevz matevz commented May 29, 2023

This PR:

  • defaults to -1 for start-block since taking the last retained block will timeout on public endpoints. You can explicitly set start-height to 0, if you want to pick the last retained block as a start block. Adds long description mentioning this.
  • replaces --write-csv and --file-csv with more standard -o or --output-file. If no output file provided, the result is printed on screen. If output file provided, the entity statistics is written only into file.
  • cosmetic UI fixes (padding, ParaTime terms, cross-OS newlines etc.)

@matevz matevz force-pushed the matevz/fix/paratime-stats branch from fd4de38 to a16f162 Compare May 30, 2023 11:56
@matevz matevz changed the title oasis paratime statistics fixes fix(cmd): Oasis paratime statistics fixes May 30, 2023
@matevz matevz merged commit c60fc0e into master May 30, 2023
2 checks passed
@matevz matevz deleted the matevz/fix/paratime-stats branch May 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants