Add macOS releases #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
reviewed
Jun 8, 2023
There was a problem hiding this comment.
Nice!
Can you also change tests (the ci-test workflow) to run on macOS? Probably can do similar as here with something like:
strategy:
matrix:
os: [ubuntu-latest, macos-latest]
# NOTE: This name appears in GitHub's Checks API.
name: tests-${{ matrix.os }}
runs-on: ${{ matrix.os }}printf is more portable, the echo on macOS behaves opposite to what was used in the Makefiles.
jberci
force-pushed
the
jberci/feature/macos
branch
from
f4b57dd
to
2dcefab
Compare
kostko
approved these changes
Jun 8, 2023
The minimum supported versions are golang defaults, i.e.: - 10.13 High Sierra for Intel builds, and - 11.0 Big Sur for Apple silicon builds.
jberci
force-pushed
the
jberci/feature/macos
branch
from
2dcefab
to
ff2fc29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the way makefiles print colorized output, similar to what was done in oasisprotocol/deoxysii-rust#22, for better compatibility with macOS.
macOS releases are universal binaries that work on either architecture, with whatever is the minimum supported system version for the go compiler (High Sierra on Intel, Big Sur on Apple silicon).