Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use stable rust #25

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Use stable rust #25

merged 1 commit into from
Feb 25, 2022

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Mar 30, 2021 •
edited

resolves #24

@nhynes nhynes requested review from kostko and Yawning March 30, 2021 17:44
@nhynes nhynes requested a review from abukosek as a code owner March 30, 2021 17:44
nhynes
nhynes commented Mar 30, 2021
View reviewed changes
benches/mrae.rs Outdated Show resolved Hide resolved
nhynes
nhynes commented Mar 30, 2021
View reviewed changes
src/tests.rs Outdated Show resolved Hide resolved
nhynes
nhynes commented Mar 30, 2021
View reviewed changes
src/primitives.rs Outdated Show resolved Hide resolved
@nhynes nhynes mentioned this pull request Mar 30, 2021
Closed
@nhynes nhynes closed this Mar 31, 2021
@nhynes nhynes reopened this Mar 31, 2021
@nhynes nhynes force-pushed the stable-rust branch 3 times, most recently from 3341b10 to c1a7029 Compare March 31, 2021 13:24
@nhynes
Copy link
Contributor Author

nhynes commented Mar 31, 2021 •
edited

Okay, I went and did a different thing. I bet you're going to complain about call overhead now.

@Yawning
Copy link
Contributor

Yawning commented Dec 8, 2021

Okay, I went and did a different thing. I bet you're going to complain about call overhead now.

Honestly a function call is "fine" as long as it always gets called when it is supposed to, because the overhead is negligible,
it won't force the power/clock speed transition penalties associated with the wide vector unit, and more importantly will not crash on SGX enabled Celeron/Pentium systems.

@nhynes
Copy link
Contributor Author

nhynes commented Feb 24, 2022

It's finally here

@nhynes nhynes merged commit d0f61a4 into master Feb 25, 2022
@nhynes nhynes deleted the stable-rust branch February 25, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@abukosek abukosek abukosek approved these changes

@peterjgilbert peterjgilbert peterjgilbert approved these changes

@Yawning Yawning Yawning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split assembly into files and compile during build script
5 participants
@nhynes @Yawning @kostko @abukosek @peterjgilbert