Improve handling of nameless ERC-20 tokens

oasisprotocol · Jun 14, 2023 · 4cfa0d0 · 4cfa0d0
1 parent a52155d
commit 4cfa0d0
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/.changelog/523.trivial.md b/.changelog/523.trivial.md
@@ -0,0 +1 @@
+Improve handling of nameless ERC-20 tokens
diff --git a/src/app/components/Account/TokenPills.tsx b/src/app/components/Account/TokenPills.tsx
@@ -40,6 +40,7 @@ type PillProps = {
 }
 
 export const Pill: FC<PillProps> = ({ account, pill }) => {
+  const { t } = useTranslation()
   const tokenRoute = RouteUtils.getAccountTokensRoute(
     account,
     account.address_eth ?? account.address,
@@ -56,7 +57,7 @@ export const Pill: FC<PillProps> = ({ account, pill }) => {
       key={pill.token_contract_addr}
       label={
         <>
-          <RoundedBalance value={pill.balance} ticker={pill.token_symbol} />
+          <RoundedBalance value={pill.balance} ticker={pill.token_symbol || t('common.missing')} />
         </>
       }
       sx={{ mr: 2 }}

diff --git a/src/app/pages/AccountDetailsPage/TokensCard.tsx b/src/app/pages/AccountDetailsPage/TokensCard.tsx
@@ -45,7 +45,7 @@ export const TokensCard: FC<TokensCardProps> = ({ type }) => {
     key: item.token_contract_addr,
     data: [
       {
-        content: item.token_name,
+        content: item.token_name || t('common.missing'),
         key: 'name',
       },
       {
@@ -68,7 +68,7 @@ export const TokensCard: FC<TokensCardProps> = ({ type }) => {
       },
       {
         align: TableCellAlign.Right,
-        content: item.token_symbol,
+        content: item.token_symbol || t('common.missing'),
         key: 'ticker',
       },
     ],

diff --git a/src/locales/en/translation.json b/src/locales/en/translation.json
@@ -59,6 +59,7 @@
     "loadMore": "Load more",
     "lessThanAmount": "< {{value}} {{ticker}}",
     "logs": "Logs",
+    "missing": "n/a",
     "name": "Name",
     "oasis": "Oasis",
     "paratime": "Paratime",