Improve token dashboard #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/token-dashboard-loading-state
branch
from
c959549
to
08fa93b
Compare
csillag
changed the title
csillag
force-pushed
the
csillag/token-dashboard-loading-state
branch
5 times, most recently
from
3a140b5
to
48056a5
Compare
lukaw3d
reviewed
Jul 10, 2023
lukaw3d
approved these changes
Jul 10, 2023
csillag
force-pushed
the
csillag/token-dashboard-loading-state
branch
from
48056a5
to
f6a78f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves two small things around the token dashboard.
Make sure there are loading states for all the cards on the dashboard
Now, while loading the token info:
Handle undefined token total supply
When a token doesn't have the token supply defined, say "undefined" instead of "n/a", as suggested by @donouwens