Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need alwaysWaitWhileLoading? #709

Open
lukaw3d opened this issue Jul 11, 2023 · 0 comments
Open

Do we need alwaysWaitWhileLoading? #709

lukaw3d opened this issue Jul 11, 2023 · 0 comments

Comments

@lukaw3d
Copy link
Member

lukaw3d commented Jul 11, 2023

Related to #691 (comment)

the current implementation of Table only considers isLoadin if there are no rows:

{!rows && isLoading && (
  <SkeletonTableRows rowsNumber={rowsNumber} columnsNumber={columns.length} />
)}

Some tables now have isLoading combining multiple requests, so rows may be available with partial data that we don't want to show yet (we have alwaysWaitWhileLoading now). On the other hand, do any tables have isLoading but data is ready to display (does any table ever rely on !rows)?

Can we unify the behavior? If not, which behavior should be the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant