Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consensus ParaTimes dashboard section #1237

Merged
merged 15 commits into from Feb 20, 2024
Merged

Consensus ParaTimes dashboard section #1237

merged 15 commits into from Feb 20, 2024

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Feb 8, 2024

No description provided.

Copy link

github-actions bot commented Feb 8, 2024

Deployed to Cloudflare Pages

Latest commit: 09f27e5df2c40ae54b2d92d5de54d9685fad5f41
Status:✅ Deploy successful!
Preview URL: https://e779db73.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/paraTimes branch 6 times, most recently from 1a78f19 to 3a3bf05 Compare February 9, 2024 10:45
@buberdds buberdds marked this pull request as ready for review February 9, 2024 11:22
src/app/components/StatusIcon/index.tsx Outdated Show resolved Hide resolved
src/app/components/StatusIcon/index.tsx Outdated Show resolved Hide resolved
src/app/pages/ConsensusDashboardPage/ParaTimesCard.tsx Outdated Show resolved Hide resolved
src/app/pages/ConsensusDashboardPage/RuntimePreview.tsx Outdated Show resolved Hide resolved
src/app/utils/route-utils.ts Outdated Show resolved Hide resolved
"active": "Active",
"activeNodes": "{{nodes}} active",
"blockNumber": "Block number:",
"inactive": "Suspended",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donouwens this implies that Cipher runtime is suspended, not just that indexer doesn't support it.
image

do we need more status options, or is this just to demo how suspended ones will look like, and we should change Cipher to "Active" but with no data?

Copy link
Contributor Author

@buberdds buberdds Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donouwens, we don't want to show new ParaTime Pontus-X here, right? Exclude it from a counter in a card header as well. I am hiding it like we do in all other places for now.

Copy link
Contributor Author

@buberdds buberdds Feb 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed "Suspended" to "Coming soon" (follows homepage terms) for now. My preference would be to remove status row entirely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect in the future we are supposed to get data from API about the actual status of runtimes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought it's rather avail/or not avail in Explorer, but yeah useRuntimeFreshness makes sense too. Will add a ticket to address this in the future.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changed "Suspended" to "Coming soon" (follows homepage terms) for now. My preference would be to remove status row entirely.

I have no clue how "suspended" ended up there, I assume I did this though 😅 - "Coming soon" is the right way indeed @buberdds

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donouwens, we don't want to show new ParaTime Pontus-X here, right? Exclude it from a counter in a card header as well. I am hiding it like we do in all other places for now.

Yes, please hide. Thanks!

@buberdds buberdds force-pushed the mz/paraTimes branch 2 times, most recently from 517a91d to 063eeae Compare February 19, 2024 12:21
@buberdds buberdds force-pushed the mz/paraTimes branch 5 times, most recently from 298a610 to 46f82e7 Compare February 19, 2024 15:58
@buberdds buberdds merged commit eb1f1fe into master Feb 20, 2024
8 checks passed
@buberdds buberdds deleted the mz/paraTimes branch February 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants