-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search by transaction hash and account address, and show search suggestions #140
Conversation
if (evmAccount) return RouteUtils.getAccountRoute(evmAccount, ParaTime.Emerald) | ||
if (consensusAccount) return RouteUtils.getAccountRoute(consensusAccount, ParaTime.Emerald) | ||
// TODO: block hash, contract, validator, event | ||
return undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this is the code that determines the priority of the various things we can search for. Has this been defined somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, no, this is just a simple implementation without supporting multiple results yet. It's not meant to prioritize search types, but just assume that they are all unique.
Multiple results will be a separate PR
Update: Scratch that, false alarm, HRM artifact... |
The placeholder in the search bar mentions "Tnx Hash, Transaction ID". I get the hash, but what is the Transaction Id, and can we really search for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed, LGTM.
Preview https://0a69944a.lw-oasis-explorer-frontend.pages.dev/
Hover and focus states:
![search](https://user-images.githubusercontent.com/3758846/219255753-1a109ec0-268c-4f79-befa-c032ddf4b89c.gif)