Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by transaction hash and account address, and show search suggestions #140

Merged
merged 7 commits into from
Feb 20, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Feb 16, 2023

if (evmAccount) return RouteUtils.getAccountRoute(evmAccount, ParaTime.Emerald)
if (consensusAccount) return RouteUtils.getAccountRoute(consensusAccount, ParaTime.Emerald)
// TODO: block hash, contract, validator, event
return undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is the code that determines the priority of the various things we can search for. Has this been defined somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no, this is just a simple implementation without supporting multiple results yet. It's not meant to prioritize search types, but just assume that they are all unique.

Multiple results will be a separate PR

@csillag
Copy link
Contributor

csillag commented Feb 16, 2023

Searching for an invalid term on the homepage doesn't result in any visible error messages. just warning on the console. Is that intentional?

Update: Scratch that, false alarm, HRM artifact...

@csillag
Copy link
Contributor

csillag commented Feb 16, 2023

The placeholder in the search bar mentions "Tnx Hash, Transaction ID". I get the hash, but what is the Transaction Id, and can we really search for it?

Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, LGTM.

@lukaw3d lukaw3d merged commit 72b9e41 into master Feb 20, 2023
@lukaw3d lukaw3d deleted the lw/search branch February 20, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants