Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable unsupported paratimes #143

Merged
merged 20 commits into from
Mar 6, 2023
Merged

Disable unsupported paratimes #143

merged 20 commits into from
Mar 6, 2023

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Feb 17, 2023 •
edited

Problem

Currently all ParaTimes are enabled. Missing tooltip on hover for desktop & bottom tooltip on mobile.

Solution

  • add useGetBoundingClientRect hook, as it was the only way of getting the right measurement of the svg components. getBBox and ResizeObserver were not reliable;
  • bounding box recalculates on scale change;
  • add desktop tooltips;
  • add mobile fixed tooltip;

Links

https://www.loom.com/share/9a5631ad0ff04fbe8d97f2a77046165e

@lubej lubej force-pushed the ml/disable-paratimes branch 4 times, most recently from f582b50 to 06ebf20 Compare February 21, 2023 08:22
@lubej lubej requested review from buberdds and lukaw3d and removed request for buberdds February 22, 2023 09:41
@lubej lubej marked this pull request as ready for review February 22, 2023 09:41
@lubej lubej force-pushed the ml/disable-paratimes branch 2 times, most recently from aa2f8ff to 4e042e0 Compare February 22, 2023 09:43
@buberdds
Copy link
Contributor

buberdds commented Feb 28, 2023 •
edited

Not sure if I have some local issues, but it looks like graph is re-rendering app quite often. I wonder if this can be a problem or it's related to issues below:

  • desktop: not able to see Emerald tooltip
  • mobile: can't see tooltips
  • mobile: not able to nav to Emerald

@lubej
Copy link
Collaborator Author

lubej commented Mar 1, 2023

Not sure if I have some local issues, but it looks like graph is re-rendering app quite often. I wonder if this can be a problem or it's related to issues below:

  • desktop: not able to see Emerald tooltip
  • mobile: can't see tooltips
  • mobile: not able to nav to Emerald

Looks like fixing lint warnings caused that. Should be resolved now.

@lubej lubej requested a review from csillag March 1, 2023 09:19
@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 3, 2023 •
edited

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c77010
Status: ✅  Deploy successful!
Preview URL: https://c243c00a.oasis-explorer.pages.dev
Branch Preview URL: https://ml-disable-paratimes.oasis-explorer.pages.dev

View logs

@lubej lubej requested a review from buberdds March 3, 2023 07:57
@lubej
Copy link
Collaborator Author

lubej commented Mar 3, 2023

TODO: Refactor file structure after review complete

buberdds
buberdds reviewed Mar 3, 2023
View reviewed changes
src/styles/theme/defaultTheme.ts Outdated Show resolved Hide resolved
src/app/pages/HomePage/index.tsx Outdated Show resolved Hide resolved
@lubej lubej requested a review from buberdds March 6, 2023 08:38
lubej added 19 commits March 6, 2023 13:41
@buberdds
Copy link
Contributor

buberdds commented Mar 6, 2023

There is some layout issue on mobile
Screenshot 2023-03-06 at 14 45 24

@lubej lubej requested a review from buberdds March 6, 2023 14:13
@lubej lubej merged commit 845b74b into master Mar 6, 2023
@lubej lubej deleted the ml/disable-paratimes branch March 6, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buberdds buberdds buberdds approved these changes

@lukaw3d lukaw3d Awaiting requested review from lukaw3d lukaw3d is a code owner

@csillag csillag Awaiting requested review from csillag csillag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lubej @buberdds