Fix gas display and document block gas limit values #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukaw3d
commented
Mar 7, 2023
lukaw3d
commented
- Documented source of gas limit values (related to b019170)
- Fixes Fix transaction details gas #130
| Before | After |
|---|---|
 |
 |
csillag
reviewed
Mar 8, 2023
| transactions: data.transactions.map(tx => { | ||
| return { | ||
| ...tx, | ||
| fee: tx.fee ? fromBaseUnits(tx.fee, paraTimesConfig.emerald!.decimals) : undefined, |
There was a problem hiding this comment.
We have a parameter called runtime, but we are still using hard-coded emerald values here. Is that intentional?
There was a problem hiding this comment.
Yeah, I'll leave that to sapphire migration PRs
csillag
approved these changes
Mar 8, 2023
Deploying with
|
| Latest commit: |
bd92cc3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://be2f355e.oasis-explorer.pages.dev |
| Branch Preview URL: | https://lw-block-gas.oasis-explorer.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.