Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display multiple search results #200

Merged
merged 9 commits into from
Mar 16, 2023
Merged

Display multiple search results #200

merged 9 commits into from
Mar 16, 2023

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Mar 10, 2023 •
edited
Loading

Blocks Transactions Accounts Mobile
localhost_1234_search_q=1650e5455c639133c707ca156aa9d43f1f11f634f446027b8cd955f7c3018ae5 (2) localhost_1234_search_q=1650e5455c639133c707ca156aa9d43f1f11f634f446027b8cd955f7c3018ae5 localhost_1234_search_q=1650e5455c639133c707ca156aa9d43f1f11f634f446027b8cd955f7c3018ae5 (1) blocks-divider

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 13, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 48dd84d
Status: ✅  Deploy successful!
Preview URL: https://3f2b78bb.oasis-explorer.pages.dev
Branch Preview URL: https://lw-search-multi.oasis-explorer.pages.dev

View logs

@lukaw3d lukaw3d marked this pull request as ready for review March 13, 2023 16:58
@lukaw3d lukaw3d force-pushed the lw/search-multi branch 3 times, most recently from 6696f2d to 5f05f90 Compare March 15, 2023 16:45
lubej
lubej approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@lubej lubej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@buberdds
Copy link
Contributor

buberdds commented Mar 16, 2023 •
edited
Loading

looks cool, just one q. When I search for a block 1201390 why there are 5 hits to blocks endpoint where 1 is to Emerald and 4 hits Sapphire ? It retries when there is no result?

@lukaw3d
Copy link
Member Author

lukaw3d commented Mar 16, 2023

Seems to be the default behavior of react-query: "Queries that fail are silently retried 3 times, with exponential backoff delay"

Changed in #217

@lukaw3d
Mock sapphire requests without affecting queryKey
65acf09 
Search results showed sapphire results as emerald results because queryKey was
the same. It did not re-run transformations that included differing layer field.
@lukaw3d
Fix sapphire search links using item.layer
48dd84d
@lukaw3d lukaw3d merged commit bbde912 into master Mar 16, 2023
@lukaw3d lukaw3d deleted the lw/search-multi branch March 16, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubej lubej lubej approved these changes

@buberdds buberdds Awaiting requested review from buberdds buberdds is a code owner

@csillag csillag Awaiting requested review from csillag csillag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukaw3d @buberdds @lubej