In TX details, display ETH hash (if available) #239
Conversation
|
Currently the ETH hash is displayed in the TX details. Where else would it be useful, @lukaw3d ? |
Deploying with
|
| Latest commit: |
86a614e
|
| Status: | ⚡️ Build in progress... |
| @@ -145,6 +145,15 @@ export const TransactionDetailView: FC<{ | |||
| <TransactionLink hash={transaction.hash} layer={transaction.layer} /> | |||
| <CopyToClipboard value={transaction.hash} /> | |||
| </dd> | |||
| {transaction.eth_hash && ( | |||
| <> | |||
| <dt>{t('common.ethHash')}</dt> | |||
There was a problem hiding this comment.
-
If tx has eth hash, that should be the only one displayed (at least until advanced user settings).
-
Lists of tx should show it, and link by it.
-
It should be displayed and copied with "0x" prefix.
There was a problem hiding this comment.
Done. One difficulty: when loading events from the API ( via the /paratime/events ), we only get a single tx_hash, which is an Oasis hash not an ETH hash, so we need to use it for linking.
csillag
force-pushed
the
csillag/display-eth-hash
branch
from
fb03558
to
a5993ba
Compare
|
There is one more thing we should consider. When displaying TX details, we can say "Hash" or "ETH hash" based on what data we find. But how to handle tables? In the header, we currently say "Hash", even if for some (or all) of the rows will have and ETH hash instead. Is this acceptable? Can we simply call both Oasis and ETH hashes "hash"? If yes, then maybe we shouldn't even try to differentiate in TX details, either.. |
(Also simplify code a bit, and handle some copy-paste errors from earlier)
csillag
force-pushed
the
csillag/display-eth-hash
branch
from
1ce07a8
to
86a614e
Compare
Fixes #169